MDEV-34391 SET PATH variable and resolution for stored routine invocations #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definition
==========
Implement the SET PATH statement. The grammar differs from the Jira
ticket where the equal sign is required:
```
SET PATH= 'schema1, schema2, schema3';
```
Function
--------
In MariaDB, the SQL-path will also be used to lookup packages in
package routine invocations, so the following script:
SET PATH='sys';
SELECT UTL_ENCODE.BASE64_DECODE('data');
invokes SYS.UTL_ENCODE.BASE64_DECODE('data'), i.e. the function
BASE64_DECODE() in the packge UTL_ENCODE in the database SYS
(if such package and package routine exist).
MariaDB implementation details
------------------------------
The ticket's requirement stated the grammar should support delimited
identifiers with backticks or double quotes within the string quote,
ie: the single tick. A simple parser was implemented to handle this
requirement in Sql_path::from_text.
Only 16 schemas are supported per session - we do not want too many
schemas in the path anyway since it will impact performance. This also
means that the path cache is a simple static array for easier memory
management.
Internal schemas (mariadb_schema, oracle_schema) are supported in paths.
Only the first internal schema in the path will be used to resolve native
routines to their respective versions.
iqbal-rsec
force-pushed
the
feature/MDEV-34391_path_squashed
branch
from
8f87435 to
9245539
Compare
cvicentiu
added
the
External Contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the SET PATH statement. The grammar differs from the Jira ticket where the equal sign is required:
SET PATH= 'schema1, schema2, schema3';Schemas within the session PATH variable will be used to resolve unqualified and qualified routine invocations.
To determine whether or not a particular routine exists within a schema/database lookups has to be performed on the proc table, so performance is impacted. To alleviate this, the PATH is empty by default - routines will be resolved using the current database as it was originally done before this implementation.
Original PR is #3566, this PR has some additional changes that fixes/simplify the parser:
=for consistency with other variablesRelease Notes
New system variable
pathhas been added.How can this PR be tested?
mysql-test/mtr path_basic path_resolutionBasing the PR against the correct MariaDB version
mainbranch.PR quality check